fix: harden backend synchronization

2026-06-02 21:06:25 +02:00
parent 4b531a4c24
commit 64b62a5793
20 changed files with 254 additions and 16 deletions
@@ -28,6 +28,10 @@ test('directadmin vacation sync creates tracked entries for enabled rule mailbox
    $calls = [];
    $api = new class($calls) extends DirectAdminVacationApi {
        public function __construct(private array &$calls) {}
+        public function vacationExists(string $owner, string $email): bool
+        {
+            return false;
+        }
        public function saveVacation(string $owner, string $email, array $rule, bool $exists): void
        {
            $this->calls[] = ['save', $owner, $email, $exists, $rule['subject']];
@@ -94,3 +98,52 @@ test('directadmin vacation sync deletes stale tracked entries after rule removal
    assert_same([['delete', 'alice', 'info@example.com']], $calls);
    assert_same([], $syncRepo->entriesForRule('alice', (string)$rule['id']));
 });
+
+test('directadmin vacation sync refuses to overwrite untracked native vacation', function (): void {
+    $virtualRoot = TEST_TMP . '/da-sync-conflict-virtual';
+    test_write($virtualRoot . '/domainowners', "example.com: alice\n");
+    test_write($virtualRoot . '/example.com/passwd', "info:x:1000:12::/home/alice/imap/example.com/info:/bin/false\n");
+
+    $dataDir = TEST_TMP . '/da-sync-conflict-data';
+    $repo = new RuleRepository($dataDir);
+    $repo->create('alice', [
+        'subject' => 'Urlop',
+        'body' => 'Body',
+        'start_value' => '2026-06-10|morning',
+        'end_value' => '2026-06-24|evening',
+        'start_ts' => 1,
+        'end_ts' => 2,
+        'enabled' => true,
+        'dynamic_scope' => true,
+    ]);
+
+    $calls = [];
+    $api = new class($calls) extends DirectAdminVacationApi {
+        public function __construct(private array &$calls) {}
+        public function vacationExists(string $owner, string $email): bool
+        {
+            return $email === 'info@example.com';
+        }
+        public function saveVacation(string $owner, string $email, array $rule, bool $exists): void
+        {
+            $this->calls[] = ['save', $owner, $email];
+        }
+    };
+
+    $sync = new DirectAdminVacationSyncService(
+        $repo,
+        new DirectAdminSyncRepository($dataDir),
+        new MailboxDirectory($virtualRoot),
+        $api
+    );
+
+    $thrown = false;
+    try {
+        $sync->syncUser('alice');
+    } catch (RuntimeException $e) {
+        $thrown = true;
+        assert_contains('Untracked DirectAdmin vacation already exists', $e->getMessage());
+    }
+    assert_true($thrown);
+    assert_same([], $calls);
+});